Restore testing on Python 2, bypassing the requires-python check when installing Setuptools. #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This technique worked for me locally. I'm not yet sure why it's not working here. |
jaraco
changed the title
jaraco
force-pushed
the
restore-python2-tests
branch
from
800b20c to
04ef944
Compare
… installing setuptools.
jaraco
force-pushed
the
restore-python2-tests
branch
from
04ef944 to
8e6b993
Compare
|
aha. I know why it's failing - because I'm invoking tox with |
jaraco
force-pushed
the
restore-python2-tests
branch
from
d2c4272 to
cb2138e
Compare
jaraco
changed the title
webknjaz
added a commit
to webknjaz/setuptools
that referenced
this pull request
Jan 14, 2020
webknjaz
added a commit
to webknjaz/setuptools
that referenced
this pull request
Jan 14, 2020
As per pypa#1961. P.S. Using `contains(['2.7', 'pypy2'], matrix.python-version)` does not work even though https://help.github.com/en/actions/automating-your-workflow-with-github-actions/contexts-and-expression-syntax-for-github-actions#contains promises arrays to be supported.
webknjaz
added a commit
to webknjaz/setuptools
that referenced
this pull request
Jan 14, 2020
As per pypa#1961. P.S. Using `contains(['2.7', 'pypy2'], matrix.python-version)` does not work even though https://help.github.com/en/actions/automating-your-workflow-with-github-actions/contexts-and-expression-syntax-for-github-actions#contains promises arrays to be supported.
webknjaz
added a commit
to webknjaz/setuptools
that referenced
this pull request
Jan 20, 2020
As per pypa#1961. P.S. Using `contains(['2.7', 'pypy2'], matrix.python-version)` does not work even though https://help.github.com/en/actions/automating-your-workflow-with-github-actions/contexts-and-expression-syntax-for-github-actions#contains promises arrays to be supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1955, this change allows the tests to run on Python 2 even though the packages declares a requirement on Python 3.5 or later. This change will prevent the risk of bit-rot on the master and maintain the expectation that Python 2 compatibility is retained for those installers not honoring PEP 345.