Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Eggsecutable Scripts #1764

Merged
merged 8 commits into from
Feb 12, 2020
Merged

Deprecated Eggsecutable Scripts #1764

merged 8 commits into from
Feb 12, 2020

Conversation

venthur
Copy link
Contributor

@venthur venthur commented May 15, 2019

Closes: #1557

Summary of changes

Deprecated "Eggsecutable Scripts" feature via warning and removed the Section in the docs.

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details

@venthur
Copy link
Contributor Author

venthur commented May 15, 2019

I'm really struggling writing a proper test for this warning. Adding another test based on the stuff in setuptools/tests/test_bdist_egg.py was not successful.

@venthur
Copy link
Contributor Author

venthur commented Aug 20, 2019

Finally got around, writing a test for the new warning.

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaraco Do you know what, if anything, is the replacement for these? When adding deprecation warnings, I think it's usually best to tell people where to go to get the same functionality, and these deprecation warnings are not helpful in that regard.

docs/setuptools.txt Outdated Show resolved Hide resolved
@jaraco
Copy link
Member

jaraco commented Aug 25, 2019

I don't know the best replacement. Doing a quick search, I see zipapp seems to implement something very similar. I haven't personally spent much time creating these apps nor have I seen them in the wild, so I can't speak to the use cases.

@venthur
Copy link
Contributor Author

venthur commented Feb 11, 2020

Any updates on this one?

@jaraco
Copy link
Member

jaraco commented Feb 12, 2020

Thanks for the ping. I can't imagine belaboring this issue any longer. I agree it would be nice to provide a replacement, but one of the goals of the PyPA has been to simplify the tool chains and limit the supported use-cases, and I think this is one of those cases, so there is no recommended replacement, at least from PyPA.

@pganssle
Copy link
Member

Thanks for the ping. I can't imagine belaboring this issue any longer.

Agreed. Assuming we give a sufficiently long deprecation period, there's always the opportunity to update the warning message if this niche in the ecosystem really needs to be filled.

@jaraco jaraco merged commit 874b7ef into pypa:master Feb 12, 2020
@hugovk hugovk mentioned this pull request Mar 22, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove reference to "eggsecutable scripts"
3 participants