Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] setuptools/_distutils/_vendor/packaging-24.0.dist-info/METADATA missing from sdist #4622

Closed
hroncok opened this issue Sep 2, 2024 · 1 comment · Fixed by #4624
Closed
Labels
bug Needs Triage Issues that need to be evaluated for severity and status.

Comments

@hroncok
Copy link
Contributor

hroncok commented Sep 2, 2024

setuptools version

74.0.0

Python version

all

OS

all

Additional environment information

No response

Description

When I download the sdist from PyPI, unpack it and run pip freeze over the vendored directories to extract the vendored versions (as the vendored.txt files are gone starting with #4457) like this:

$ pip freeze --path setuptools/_vendor
$ pip freeze --path setuptools/_distutils/_vendor

I get:

$ pip freeze --path setuptools/_vendor 
autocommand==2.2.2
backports.tarfile==1.2.0
importlib_metadata==8.0.0
importlib_resources==6.4.0
inflect==7.3.1
jaraco.context==5.3.0
jaraco.functools==4.0.1
jaraco.text==3.12.1
more-itertools==10.3.0
packaging==24.1
platformdirs==4.2.2
tomli==2.0.1
typeguard==4.3.0
typing_extensions==4.12.2
wheel==0.43.0
zipp==3.19.2

$ pip freeze --path setuptools/_distutils/_vendor
WARNING: Skipping setuptools/_distutils/_vendor/packaging-24.0.dist-info due to invalid metadata entry 'name'

Namely, this doesn't work because setuptools/_distutils/_vendor/packaging-24.0.dist-info is incomplete:

$ tree setuptools/_distutils/_vendor/packaging-24.0.dist-info
setuptools/_distutils/_vendor/packaging-24.0.dist-info
├── LICENSE
├── LICENSE.APACHE
└── LICENSE.BSD

1 directory, 3 files

While in git:

$ tree setuptools/_distutils/_vendor/packaging-24.0.dist-info
setuptools/_distutils/_vendor/packaging-24.0.dist-info
├── INSTALLER
├── LICENSE
├── LICENSE.APACHE
├── LICENSE.BSD
├── METADATA
├── RECORD
├── REQUESTED
└── WHEEL

1 directory, 8 files

Please include setuptools/_distutils/_vendor/packaging-24.0.dist-info/METADATA in sdist or restore the vendored.txt files.

Thank you.

Expected behavior

$ pip freeze --path setuptools/_vendor 
autocommand==2.2.2
backports.tarfile==1.2.0
importlib_metadata==8.0.0
importlib_resources==6.4.0
inflect==7.3.1
jaraco.context==5.3.0
jaraco.functools==4.0.1
jaraco.text==3.12.1
more-itertools==10.3.0
packaging==24.1
platformdirs==4.2.2
tomli==2.0.1
typeguard==4.3.0
typing_extensions==4.12.2
wheel==0.43.0
zipp==3.19.2

$ pip freeze --path setuptools/_distutils/_vendor
packaging==24.0

How to Reproduce

see above

Output

see above

@hroncok hroncok added bug Needs Triage Issues that need to be evaluated for severity and status. labels Sep 2, 2024
hroncok added a commit to hroncok/setuptools that referenced this issue Sep 2, 2024
@hroncok
Copy link
Contributor Author

hroncok commented Sep 2, 2024

Fix in #4623

@jaraco jaraco mentioned this issue Sep 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
1 participant