-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building wheels with a -
produces wheels with _
.
#4214
Comments
The wheel name
That expectation matches with the fact that the wheels have underscores in the names of releases going back to September. |
@mattip Can you possibly distill the scipy-openblas64 build instructions into something I can replicate or even better provide a minimal reproducer (ideally something that doesn't rely on a compiler)? I'm struggling to see when/how the naming is no longer meeting expectations. Could it be that the problem is that the uploader is assuming that the name in the wheel is correct when it in fact is not, and it should instead be extracted from the wheel metadata (where the dash is present)? |
That makes sense. The wheel created has the |
Feel free to close this, sorry for the noise. |
I opened anaconda/anaconda-client#704 |
This broke building packages with dashes in their names from source, including this one. As of a recent release of `setuptools`, sdist filenames now are in the format `package_name-<version>.tar.gz` instead of `package-name-<version>.tar.gz` (i.e. underscores in the package name instead of dashes). This is the case even if the package name itself has dashes in it. pypa/setuptools#4214 pypa/setuptools#4167 This change is seemingly deliberate in order to conform to a standard for filenames specifically even though the standard for project names is increasingly to use dashes.
…ect for its output name ### What changes were proposed in this pull request? This PR proposes to replace `pyspark-connect` to `pyspark_connect` for its output name. ### Why are the changes needed? `setuptools` from 69.X.X changes the output name. It replaces dash in package name to underscore (`pyspark_connect-4.0.0.dev1.tar.gz` vs `pyspark-connect-4.0.0.dev1.tar.gz`), I think it is pypa/setuptools#4214. ### Does this PR introduce _any_ user-facing change? No, this package has not been released out yet. ### How was this patch tested? Manually tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46751 from HyukjinKwon/SPARK-48425. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
…ect for its output name ### What changes were proposed in this pull request? This PR proposes to replace `pyspark-connect` to `pyspark_connect` for its output name. ### Why are the changes needed? `setuptools` from 69.X.X changes the output name. It replaces dash in package name to underscore (`pyspark_connect-4.0.0.dev1.tar.gz` vs `pyspark-connect-4.0.0.dev1.tar.gz`), I think it is pypa/setuptools#4214. ### Does this PR introduce _any_ user-facing change? No, this package has not been released out yet. ### How was this patch tested? Manually tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46751 from HyukjinKwon/SPARK-48425. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
I think #4159 might have changed wheel building for projects with a
-
in the project name (from the project'spyproject.toml
). Now the wheel filename for a project likescipy-openblas64
will becomescipy_openblas64-0.3.26-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
. When usingtwine
to upload to PyPI the name is converted back toscipy-openblas64
, but the anaconda uploader will respect the_
and try to upload toscipy_openblas64
. See scientific-python/upload-nightly-action#61Originally posted by @mattip in #4159 (comment)
The text was updated successfully, but these errors were encountered: