-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] AttributeError: pakcage_dir typo breaks editable installs #3498
Comments
Thank you very much for reporting this @agroszer. |
Unsure if related, but since this morning all of our packages have began breaking with the following:
Setting |
Hi @synchronizing, thank you for reporting that. It is probably a different problem, could you open a new issue with a reproducer? Meanwhile we investigate/fix the problem you can try using |
Both the env, and non-editable installations work. The issue started this morning, however, and was not present pre-64.0.0. This did cause a few of our deployments to break suddenly, so the reason I'm here now. Will open new issue, thank you. |
In my case, it was indeed an editable dep breaking my testing environment that led me to find the typo in #3497 |
Sorry for the inconvenient @leonixyz. Thank you for providing the fix. If that is OK with you, I was planning to wait and see if we can also investigate and fix the second problem reported by |
@abravalheri Opened issue #3500. Similar issue opened in #3499, #3501. |
The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins.
@abravalheri looks like a bunch of other issues arose.... please merge and release |
@agroszer, sorry for the delay. Due to the time the CI takes to run, it is good to group all the fixes together. Please let me know v64.0.1 solves your problem. I can re-open the ticket if necessary. |
* Pin setuptools in CI The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins. * Remove pip/setuptools/wheel manual install step * Try venv instead of virtualenv * Revert "Try venv instead of virtualenv" This reverts commit 3ada819. * Revert "Remove pip/setuptools/wheel manual install step" This reverts commit 831bc6e. * Pin in constraints.txt too * Lower version further * Pin setuptools-rust too * Set editable install to legacy mode via env var * Set env variable correctly everywhere we build terra * Add missing env variable setting for image tests
thanks that fixes it |
* Pin setuptools in CI The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins. * Remove pip/setuptools/wheel manual install step * Try venv instead of virtualenv * Revert "Try venv instead of virtualenv" This reverts commit 3ada819. * Revert "Remove pip/setuptools/wheel manual install step" This reverts commit 831bc6e. * Pin in constraints.txt too * Lower version further * Pin setuptools-rust too * Set editable install to legacy mode via env var * Set env variable correctly everywhere we build terra * Add missing env variable setting for image tests (cherry picked from commit 82e38d1)
* Pin setuptools in CI The recently released setuptools 64.0.0 release introduced a regression that prevents editable installs from working (see pypa/setuptools#3498). This is blocking CI as we use editable installs to build and install terra for testing. When there is an upstream release fixing this issue we can remove the pins. * Remove pip/setuptools/wheel manual install step * Try venv instead of virtualenv * Revert "Try venv instead of virtualenv" This reverts commit 3ada819. * Revert "Remove pip/setuptools/wheel manual install step" This reverts commit 831bc6e. * Pin in constraints.txt too * Lower version further * Pin setuptools-rust too * Set editable install to legacy mode via env var * Set env variable correctly everywhere we build terra * Add missing env variable setting for image tests (cherry picked from commit 82e38d1) Co-authored-by: Matthew Treinish <[email protected]>
setuptools version
64.0.0
Python version
3.9
OS
ubuntu
Additional environment information
7ae5a69 introduced the typo
Description
Doing the obvious
bin/pip install --upgrade -r "data/versions/requirements.txt"
where requirements.txt has:
-e .
Expected behavior
.
How to Reproduce
.
Output
The text was updated successfully, but these errors were encountered: