Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VendorImporter doesn’t have find_spec() method #2104

Closed
manueljacob opened this issue May 11, 2020 · 3 comments
Closed

VendorImporter doesn’t have find_spec() method #2104

manueljacob opened this issue May 11, 2020 · 3 comments
Labels
deferred enhancement help wanted

Comments

@manueljacob
Copy link

sys.meta_path entries should have a find_spec() method. As a fallback, importlib calls find_module(), but other users might not.
@jaraco
Copy link
Member

jaraco commented May 13, 2020

Thanks manueljacob. Would you consider putting together a patch?

@jaraco
Copy link
Member

jaraco commented May 15, 2020

Actually, let's put this effort on hold until #2052 is resolved, as that may remove the VendorImporter entirely.

@jaraco jaraco closed this as completed May 15, 2020
@manueljacob
Copy link
Author

Thanks. For now, I worked around the problem. For reference: https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-May/141648.html

DougBurke added a commit to DougBurke/sherpa that referenced this issue May 1, 2023
@DougBurke
CI: catch unexpected warning messages
18f17cc 
The CI runs of sherpa#1752 after
pulling in this branch sherpa#1753
started to fail because of a warning message that I could not
replicate. A search lead to this set of issues

- pypa/setuptools#2104
- pypa/setuptools#2052
- pypa/setuptools#1383

which suggests there's a subtle interaction between pip and
setuptools that we are falling over. As we currently have setuptools
pinned to < 60, whilst the distutils changes coming in Python 3.12
work through the ecosystem, the OTS code we run is likely to
hit this issue (i.e. nothing we can fix) so we can just skip the
warnings. Hopefully we can remove these additions soon.
@nicoddemus nicoddemus mentioned this issue May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deferred enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaraco @manueljacob