combined preparation for the 6.3.0 release and a regression resolution #616
Conversation
Co-authored-by: Filipe Laíns <[email protected]>
| if int(_version.split(".")[0]) < 45: | ||
| raise SystemExit( | ||
| f""" | ||
| ERROR: setuptools=={_version} is used in combination with setuptools_scm>=6.x |
There was a problem hiding this comment.
this should probably read 7.x?
Co-authored-by: wouter bolsterlee <[email protected]>
* detach from packaging version parsing/class and integrate backward compat mixin * move version classes to own internal module * don't warn when pyproject.toml is missing * consistently fetch dist name from setup.cfg * extend warning with notes on minimal versions * trace to stderr instead of stdout * create extensive tests around running on old setuptools
…ools_scm into fix-regressions
RonnyPfannschmidt
changed the title
| next to ``setup.py``, which would install the required version of setuptools. | ||
|
|
||
| This mechanism has long since been deprecated and removed | ||
| as most people haven't been using it |
There was a problem hiding this comment.
| as most people haven't been using it | |
| as most people haven't been using it. |
There was a problem hiding this comment.
Also, on this block, mentioning what version is too old and going to produce the warning might be helpful. This starts by saying "warns on legacy" but then says "all releases are affected", it's really unclear, I think. Maybe I could suggest a new version?
This release explicitly warns on unsupported setuptools. When using the legacy
``setup_requires`` mechanism, you cannot request a newer setuptools than the
one currently running (this was the reason PEP 517 and PEP 518 were written).There was a problem hiding this comment.
all setuptools releases are affected by the issue, even those that dont trigger legacy problems
There was a problem hiding this comment.
Yes, but this is a general issue that has nothing to do with setuptools_scm, it's just easy to hit with it. The current message makes it sound like it's a major issue that most users will hit, while in actuality, now that 31+ is supported instead of 45+, it's only going to pop up in very old systems - which you should be unlikely to hit with Python 3.6+ (though possible). My suggested replacement makes it sound a little less drastic and pushes people gently toward PEP 517/518, which avoids triggering legacy behavior.
| if int(_version.split(".")[0]) < 45: | ||
| raise SystemExit( | ||
| f""" | ||
| ERROR: setuptools=={_version} is used in combination with setuptools_scm>=6.x |
Co-authored-by: Henry Schreiner <[email protected]>
RonnyPfannschmidt
force-pushed
the
fix-regressions
branch
from
2a4ef88 to
7ccb483
Compare
RonnyPfannschmidt
force-pushed
the
fix-regressions
branch
from
901853e to
7b65699
Compare
this fixes the support for old setuptools while not starting to claim to support old setuptools
setup.pyas well