-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to keep the version when changing tracked files? #1006
Comments
that use-case not supported by normal means and will never be directly supported |
Thanks! The workaround works for me. In the GitHub Action, I get the version and set
|
Fix #3168. See: pypa/setuptools-scm#1006 (comment) --------- Signed-off-by: Jinzhe Zeng <[email protected]>
* Fix max nbor size related issues (deepmodeling#3157) * Merge master into devel (deepmodeling#3167) * [pre-commit.ci] pre-commit autoupdate (deepmodeling#3163) <!--pre-commit.ci start--> updates: - [github.com/astral-sh/ruff-pre-commit: v0.1.13 → v0.1.14](astral-sh/ruff-pre-commit@v0.1.13...v0.1.14) <!--pre-commit.ci end--> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * setup PyTorch C++ interface build environement (deepmodeling#3169) See deepmodeling#3120. - CMake: add `ENABLE_TENSORFLOW` and `ENABLE_PYTORCH`. `BUILD_TENSORFLOW` will be enabled when `TENSORFLOW_ROOT` is not empty or `USE_TF_PYTHON_LIBS` is on. - api_cc: add `BUILD_TENSORFLOW` and `BUILD_PYTORCH` defination. Move several functions from `common.h` to `commonTF.h` to prevent exposing them to header files. - CI: download libtorch in the build/test CC actions. --------- Signed-off-by: Jinzhe Zeng <[email protected]> * docs: add TF icons to platform-specific features (deepmodeling#3171) Fix deepmodeling#3121. The PyTorch icon can be added when a feature implemented by PyTorch is added. However, I can't find a way to add an icon to TOC. ![image](https://github.com/deepmodeling/deepmd-kit/assets/9496702/7f29da27-af81-4850-9da0-79310d216b2d) Signed-off-by: Jinzhe Zeng <[email protected]> * add universal Python inference interface DeepPot (deepmodeling#3164) Need discussion for other classes. --------- Signed-off-by: Jinzhe Zeng <[email protected]> * detect version in advance before building deepmd-kit-cu11 (deepmodeling#3172) Fix deepmodeling#3168. See: pypa/setuptools-scm#1006 (comment) --------- Signed-off-by: Jinzhe Zeng <[email protected]> --------- Signed-off-by: Jinzhe Zeng <[email protected]> Co-authored-by: Denghui Lu <[email protected]> Co-authored-by: Jinzhe Zeng <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ng#3172) Fix deepmodeling#3168. See: pypa/setuptools-scm#1006 (comment) --------- Signed-off-by: Jinzhe Zeng <[email protected]> (cherry picked from commit 5dfbb55)
Fix #3168. See: pypa/setuptools-scm#1006 (comment) --------- Signed-off-by: Jinzhe Zeng <[email protected]> (cherry picked from commit 5dfbb55)
@njzjz Would you please provide a link to the GH action you amended? |
@CatChenal You can check deepmodeling/deepmd-kit#3172. The version will be bumped if any of the git-tracked files is changed. |
Thanks Jinzhe! That's a great project! |
I use setuptools_scm through scikit-build-core. |
Thank you, I missed that.
Best regards,
Cat Chenal, Ph.D.
…On Tue, Feb 20, 2024 at 6:08 PM Jinzhe Zeng ***@***.***> wrote:
I use setuptools_scm through scikit-build-core
<https://scikit-build-core.readthedocs.io/en/latest/configuration.html#dynamic-metadata>
.
—
Reply to this email directly, view it on GitHub
<#1006 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEL5OMTUQSTET2TRN2L3CDYUUUGDAVCNFSM6AAAAABCGMZ6XKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGI4DCMJQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I have read #717 and #812, but neither provides a solution.
I need to release several packages with different package names. PEP 621 requires a static
name
(see discussion), so I have to updatepyproject.toml
, which is tracked bygit
. However, afterpyproject.toml
is changed in the CI, the version is bumped, making it impossible to upload to PyPI.In the above situation, I tagged
v2.2.8
, the GitHub Actions updatedname
inpyproject.toml
, and thensetuptools-scm
gave the version2.2.9.dev0+gb875ea8f.d20240123
. PyPI rejected the package with this version. I'd like to know if there is a way to get the version2.2.8
even when a tracked file is changed. Thanks!The text was updated successfully, but these errors were encountered: