Correct editable metadata hook return type to str #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`prepare_metadata_for_build_wheel` was initially typed to return Optional[str] just like the editable metadata hook, but it got changed to `str` during review. However, the editable hook's return type was never corrected. This seems to be an oversight as I can't find anything in the PEP 517 or 660 specifications allowing these hooks to return None.
|
You could probably drop Python 3.7 support to make the checks green again. It looks like it was previously dropped with 69ed8b1 but that was reverted 9cf1649 it seems it was kept because |
matthewhughes934
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare_metadata_for_build_wheelwas initially typed to returnOptional[str]just like the editable metadata hook, but it got changed tostrduring review. However, the editable hook's return type was never corrected. This seems to be an oversight as I can't find anything in the PEP 517 or 660 specifications allowing these hooks to return None.