-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1509 short-circuit of installing packages when already installed #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
ayemiller
changed the title
Fixes short-circuit of installing packages when already installed
Issue #1509 short-circuit of installing packages when already installed
Aug 17, 2024
ayemiller
changed the title
Issue #1509 short-circuit of installing packages when already installed
Fixes #1509 short-circuit of installing packages when already installed
Aug 17, 2024
Thanks for catching! Probably, we don't need two tests, though. Besides, the test function names don't really correspond to the actual test procedure.. |
Whoops! Updated :) |
chrysle
reviewed
Aug 17, 2024
chrysle
previously approved these changes
Aug 18, 2024
chrysle
reviewed
Aug 18, 2024
Co-authored-by: chrysle <[email protected]>
chrysle
approved these changes
Aug 18, 2024
Gitznik
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/
(if the patch affects the end users)Summary of changes
Updates logic of
install.py
to continue installing packages if one is already installed.Test plan
Added tests to exercise the bug and demonstrate fix:
test_install_three_packages_with_first_already_installed
test_install_two_packages_with_first_two_already_installed
Tested by running