Assorted repo-review suggestions #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
repo-review
branch
6 times, most recently
from
9026ecc to
a22267d
Compare
uranusjr
reviewed
Aug 5, 2024
Apply repo-review rule PP302: Must have a minversion=, and must be at least 6 (first version to support pyproject.toml configuration).
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
a22267d to
c8d4f68
Compare
Apply repo-review rule PP303: The `testpaths` setting should be set to a reasonable default.
Apply repo-review rule PP304: log_cli_level should be set. This will allow logs to be displayed on failures.
Apply repo-review rule PP306: --strict-config should be in addopts = [...]. This forces an error if a config setting is misspelled.
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
6731461 to
aa26f14
Compare
Apply repo-review rule PP307: --strict-markers should be in addopts = [...]. This forces all markers to be specified in config, avoiding misspellings.
Apply repo-review rule PP308: An explicit summary flag like -ra should be in addopts = [...] (print summary of all fails/errors).
|
I've left out these I might try to add them in a different PR. |
Apply repo-review rule PC191: If --fix is present, --show-fixes must be too.
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
e62f572 to
44b5d12
Compare
uranusjr
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Summary of changes
Changes suggested by repo-review:
https://learn.scientific-python.org/development/guides/repo-review/?repo=pypa%2Fpipx&branch=main
Test plan
Pass CI tests.