Move --global option into shared parser #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysle
previously approved these changes
May 11, 2024
1 task
chrysle
approved these changes
May 11, 2024
|
Dumb question: If not, then If both positions are accepted, then forget what I've said |
|
Yes, both positions are accepted. |
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/pipx
that referenced
this pull request
May 12, 2024
* Move `--global` option into shared parser * Add changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update tests --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/pipx
that referenced
this pull request
May 12, 2024
* Move `--global` option into shared parser * Add changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update tests --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Summary of changes
Move
--globaloption into shared parser, such that it can be passed after the subcommand, for examplepipx ensurepath --global.Test plan
Tested by running