Validate package(s) argument should not be path(s). #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
previously approved these changes
Apr 24, 2024
huxuan
force-pushed
the
xuan.hu/package_is_abspath
branch
3 times, most recently
from
6035595 to
a754a89
Compare
dukecat0
reviewed
Apr 27, 2024
huxuan
force-pushed
the
xuan.hu/package_is_abspath
branch
from
91eaddb to
76b6266
Compare
dukecat0
reviewed
Apr 27, 2024
huxuan
force-pushed
the
xuan.hu/package_is_abspath
branch
from
2deca1b to
934d394
Compare
dukecat0
previously approved these changes
Apr 28, 2024
chrysle
reviewed
Apr 28, 2024
huxuan
force-pushed
the
xuan.hu/package_is_abspath
branch
2 times, most recently
from
5bcbd02 to
96af17f
Compare
Co-authored-by: Jason Lam <[email protected]>
Co-authored-by: chrysle <[email protected]>
huxuan
force-pushed
the
xuan.hu/package_is_abspath
branch
from
96af17f to
d821db6
Compare
dukecat0
changed the title
dukecat0
approved these changes
Apr 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Summary of changes
Fix #1354
Test plan
Tested by running