Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/comparisons: Add pae/pactivate #1211

Merged
merged 10 commits into from
Jan 18, 2024
Merged

docs/comparisons: Add pae/pactivate #1211

merged 10 commits into from
Jan 18, 2024

Conversation

0cjs
Copy link
Contributor

@0cjs 0cjs commented Jan 16, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

(Does not affect users of the program; documentation update only.)

Summary of changes

Add comparison with a somewhat similar tool, pae/pactivate.

Test plan

Tested by regenerating the documentation with nox -s build_docs and reading the new output in site/comparisons/index.html.

docs/comparisons.md Outdated Show resolved Hide resolved
docs/comparisons.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the docs :)

docs/comparisons.md Outdated Show resolved Hide resolved
docs/comparisons.md Outdated Show resolved Hide resolved
docs/comparisons.md Outdated Show resolved Hide resolved
@0cjs
Copy link
Contributor Author

0cjs commented Jan 17, 2024

Note that I'm putting up separate commits on the dev branch for each separate conversation here; I believe this should make reviewing easier. I'll of course squash these all into one commit when we're ready to merge, unless you guys think that this history here should be kept.

@0cjs
Copy link
Contributor Author

0cjs commented Jan 17, 2024

I've just added a new bullet point near the top that I think more precisely explains a core difference in approach between pipx and pae. I realise this whole thing may be getting a bit long; I'm open to removing whatever you think isn't too important. (I could also add a section in the pae/pactivate documentation with a detailed comparison with pipx, and we could just summarize here and link to that, if that sounds like a better idea.)

@0cjs
Copy link
Contributor Author

0cjs commented Jan 17, 2024

By the way, I did play with the pipx inejct command to inject other packages into a virtual environment, but it didn't create links in my ~/.local/bin/ for the CLI programs in it. And actually even programs for dependencies don't get links. (I do believe that both these decisions are correct for pipx.) Is there any way with pipx to run an arbitrary program from a specific virtual environment other than giving the full path to it, e.g., ~/.local/share/pipx/venvs/grip/bin/flask --version?

@0cjs
Copy link
Contributor Author

0cjs commented Jan 18, 2024

Ok, I've created a detailed comparison in the pactivate documentation, and slimmed down the one here to cover just the essentials and link to the details. Thoughts?

(As usual, this is a separate commit on the end; a squash will bring the whole set down to just what's on the end.)

@gaborbernat gaborbernat enabled auto-merge (squash) January 18, 2024 15:47
@gaborbernat gaborbernat requested a review from Gitznik January 18, 2024 15:47
@gaborbernat gaborbernat merged commit a87390e into pypa:main Jan 18, 2024
12 checks passed
@0cjs 0cjs deleted the dev/cjs/24a16/compare-pae branch January 19, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants