fix: nicer tracebacks in run mode on scripts

[henryiii]

This is one way to improve the tracebacks as reported in #1187 and mentioned in #1180.

• I have added an entry to docs/changelog.md

Summary of changes

This is the simplest way I initially see to get filenames. Instead of passing around the contents of the script as a string, scripts are passed around as Paths, which allows the run command to run the path rather than passing the string on the command line.

Test plan

If you start with this script:

import httpx

You get this:

$ pipx run ./script.py
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import httpx
ModuleNotFoundError: No module named 'httpx'

After this PR, you get this:

$ pipx run ./script.py
Traceback (most recent call last):
  File "/Users/henryschreiner/git/software/pipx/script.py", line 1, in <module>
    import httpx
ModuleNotFoundError: No module named 'httpx'

[flying-sheep]

Looks lovely! I think there could be some slight deduplication, otherwise wonderful!

My motivation for this is that people can now use this pipx functionality in scripts instead of directly, in which case this PR’s changes will come in handy for debugging.

[chrysle]

Looks good!

[chrysle]

I think we should really enable merge queues, this constant branch updating is annoying.

[rsalmaso]

Happy for this patch!

Running script instead of string solve another problem: run the script via shebang #!/usr/bin/env -S pipx run and get the correct filename sys.argv[0].

[dukecat0]

Test please

[henryiii]

What should this do if a URI is passed, by the way? Currently that still says "<string>". That could be a future improvement, but something to think about.

[dukecat0]

What should this do if a URI is passed, by the way? Currently that still says "". That could be a future improvement, > but something to think about.

Perhaps we can have an additional check here?

pipx/src/pipx/commands/run.py

Line 57 in 5563ae6

if urllib.parse.urlparse(app).scheme:

[henryiii]

A check wouldn't help, we are already doing the "right" think (since when getting a URI it needs to be downloaded, possibly from a remote source), it's just then a question of if there's a way to get it to show something nicer than "<string>". This was fixable since loading a local file can just be directly run by the python command. I would assume there's a way to customize running on arbitrary input, since things like IPython do it (though at in least some cases, they write out temporary files).

IMO the big one to fix though is the one in this PR, with URI's being a second, smaller improvement later. I'd expect running on a local file to give the right traceback, not sure I'd expect it from an arbitrary URI.

[gaborbernat]

Let's rebase and add changelog.