-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Bump changelog on release" GH Action #1188
Conversation
f6e2fb5
to
3e09187
Compare
Wouldn't it be better to have it make a PR? That's what I was intending to do later. |
@henryiii I thought merging that every time would mean increased effort, but I guess you're right. If you don't insist on doing it, I could also configure it in this PR (I'd use GH CLI). |
a79aae0
to
7a69441
Compare
You are welcome to do it. :) I think you can use the gh CLI, I've intended to try with that, I've used https://github.com/peter-evans/create-pull-request before and it works well. You do have to close and reopen to trigger CI unless you set up a bot, which I haven't done yet. https://github.com/scientific-python/cookie/blob/main/.github/workflows/bump.yml is one I've set up, another is https://github.com/pypa/cibuildwheel/blob/main/.github/workflows/update-dependencies.yml which does have the bot. |
I've already pushed an attempt, could you have a look? |
I haven't tried gh for this, so I don't want to guarantee anything, but it looks correct and like what I would have tried, I think. |
dc21064
to
a3f1192
Compare
for more information, see https://pre-commit.ci
a3f1192
to
6684eb2
Compare
…nto fix-bump-changelog-action
@henryiii @dukecat0 I don't seem to be able to test this fully on my fork (see this actions run), but judging by what does work there, this should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need the |
Fix in #1202, it was missing |
docs/changelog.md
Summary of changes
Basically I made sure I'm allowed to bypass the branch protection rules and configured the action to commit with my identity.
I think we shouldn't remove the branch protection.
This ought to close #1185.
Test plan
Tested by running