Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Running pipx From Source Tree" section #1183

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Jan 2, 2024

  • I have added an entry to docs/changelog.md

Summary of changes

Running pipx from source isn't possible any more since #1130 (removal of the pipx.version module). Therefore I removed
the corresponding section in CONTRIBUTING.md.

Test plan

Tested by running

# command(s) to exercise these changes

@dukecat0
Copy link
Member

dukecat0 commented Jan 2, 2024

Edit: it's because I've run pip install -e . before. Maybe we should replace python src/pipx --version with this command?

Seems like it can still be run correctly:

$ python src/pipx --version
1.4.1.dev5+g98dad34

@chrysle chrysle force-pushed the update-contributing branch from 2380f32 to b7ffeaa Compare January 3, 2024 14:54
@chrysle chrysle changed the title Remove "Running pipx From Source Tree" section Update "Running pipx From Source Tree" section Jan 3, 2024
@chrysle
Copy link
Contributor Author

chrysle commented Jan 3, 2024

Good idea, done. I also removed the enabled argument from the search plugin configuration in mkdocs.yml. It somehow broke the MkDocs build, and is set to true by default anyway.

@dukecat0 dukecat0 enabled auto-merge (squash) January 3, 2024 15:03
@dukecat0 dukecat0 merged commit 38a0491 into pypa:main Jan 3, 2024
14 checks passed
@chrysle chrysle deleted the update-contributing branch June 3, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants