-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify if script name provided is a file before running it #1155
Conversation
Didn't you want to detect whether the file is a valid script? |
Co-authored-by: Tzu-ping Chung <[email protected]>
I think a file that has no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test please 👍
Not sure if we need a test for this...? I personally think this is a very minor bug and doesn't require a test. |
I disagree. Every bug fix must have a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests please.
Added |
for more information, see https://pre-commit.ci
docs/changelog.md
Summary of changes
pipx run
: Verify whether the script name provided is a file before running itCloses #1152
Test plan
Tested by running