upgrade pip when upgrading packages #72

pypa · Jan 27, 2019 · e3e7f41 · e3e7f41
1 parent 181ee7b
commit e3e7f41
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+dev
+* upgrade pip when upgrading packages #72
+
 0.10.4.1
 * Fix version printed when `pipx --version` is run
 

diff --git a/pipx/main.py b/pipx/main.py
@@ -413,6 +413,13 @@ def upgrade(
 
     old_version = venv.get_package_version(package)
     do_animation = not verbose
+    try:
+        with animate(f"upgrading pip for package {package_or_url!r}", do_animation):
+            venv.upgrade_package("pip", pip_args)
+
+    except Exception:
+        logging.error("Failed to upgrade pip", exc_info=True)
+
     with animate(f"upgrading package {package_or_url!r}", do_animation):
         venv.upgrade_package(package_or_url, pip_args)
     new_version = venv.get_package_version(package)