-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate metadata from setup.py to setup.cfg #5900
Conversation
Did you read the first line of the commit message above? I am highly supportive of 5836 but it is failing its tests. I thought we could advance step-by-step until we can rebase 5836 in a way that passes all tests. Please feel free to close this PR with unmerged commits. |
We can keep it open -- I am not sure what path would be better and I am not opinionated in this case. CC @kalebmckale |
Oh... Now that I see: + pip install build
# ...
- python -m pipenv run python setup.py sdist bdist_wheel
+ python -m pipenv run python -m build in #5836, that makes MUCH more sense. |
long_description = file: README.md | ||
name = pipenv | ||
author = Pipenv maintainer team | ||
author_email = [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should figure out something to change this to at some point since that email list is gone.
Closing in favor of #5836 |
Perhaps a step towards #5836
This pull request was created using https://pypi.org/project/setuptools-py2cfg plus manual modifications.
https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use
After a pull request like this is tested and merged, I usually do a follow-up PR like...
PEP 621: Migrate settings from setup.cfg into pyproject.toml
Migrate settings from
setup.cfg
intopyproject.toml
using ini2toml to do the file conversion and running pyproject-fmt and then validate-pyproject in pre-commit to validate the results.pyproject.toml
so move its settings into.flake8
.https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use
Ran
validate-pyproject
to validate the results.From
validate-pyproject
README: