-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for python3.7 #5879
Conversation
I will be holding off on this one until we are satisfied that the recent releases are working for the majority of use cases. |
Also, this change will conflict with: #5836 |
No worries, I will wait. And no worries for the conflicting change, I will update my PR, the conflict won't be a big thing. |
I will resume work now that #5836 is merged. |
It is time to take this up again. |
e530a45
to
f7ae8f1
Compare
I think we're good. |
pyptoject.toml needs to remove the python 3.7 support line or else the pip resolver will still try to install this for 3.7 versions. |
Also please add a news fragment stating we are dropping support for 3.7 |
Sorry, some changes had not been pushed. I attempted to go a step more in the cleaning, the even more cleaning commit, but I got errors I did not understand so I reverted it. If you can tell me what was wrong, it could be done in a different PR. |
Arg. It should have been squash-merged. But thank you. |
@deronnax I've gotten feedback both ways -- usually people want the regular merge because if I squash merge it gives me credit for your commit or something -- anyway, thanks for your contribution! Worst case is the revert button from the PR will undo the whole changeset |
The issue
Drop support for Python 3.7
The fix
It's obvious
The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #. : incoming