-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safety 2 use without a subprocess #5476
Safety 2 use without a subprocess #5476
Conversation
@yeisonvargasf your vendoring stage is failing because you started off with an outdated branch. Please cherry-pick this commit onto your branch; |
@yeisonvargasf can you please rebase your changes on top of the current main branch? |
* Vendor safety==2.1.1 cleanly with ruamel. * Apply more minimal patch to safety.
* Bump python version required * Add install instructions for gentoo * Update usage output from `pipenv --help`
…ue pipenv commands.
Invoke does not support Python3.11
d529381
to
602bd0c
Compare
Thanks, @oz123! I rebased my changes on top of the current main branch. The PR base branch is the @matteius branch; do we need to change the On the other hand, running the tests in my local environment fails because Safety detects a vulnerability in the tested environment. Could you help to review that? After the test issue is solved, we'll need vendoring the latest Safety version that PyUp will release next week; it fixes an issue related to |
@yeisonvargasf we don't have |
@yeisonvargasf I don't know if you could go back to the way this branch was before the attempted rebase? It probably would have worked smoother to have merged main branch changes into this fork/branch instead of how this rebase was done. |
I can update my branch with the latest main changes now if that helps, you can continue to target that branch, but right now the commit history here seems corrupted from the rebasing, perhaps you can cherry-pick your original commits to a new branch off my updated branch? |
I have pushed the updated changes from main to my branch |
I think the same, so sure, @matteius; I'll create a new branch and make a new PR with the |
The issue
The pipenv new Safety implementation is using a subprocess.
There isn't a non-verbose output.
This pull request is related to #5218
The fix
pipenv check
uses Safety directly, replacing the Safety implementation with a subprocess.Added a new
minimal
output, a non-verbose output.