Allow pipenv option to consider all listed package sources when syncing the Pipfile.lock #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
changed the title
matteius
changed the title
This was referenced Apr 14, 2022
oz123
reviewed
Apr 15, 2022
| @@ -1484,23 +1482,26 @@ def pip_install( | |||
| ignore_hashes = False | |||
| line = None | |||
| # Try installing for each source in project.sources. | |||
| search_all_sources = project.settings.get("install_search_all_sources", False) | |||
There was a problem hiding this comment.
Should we add public facing documentation for this option?
There was a problem hiding this comment.
Yes -- I am going to add that once we decide if this should be what its name is.
There was a problem hiding this comment.
I think the name install_search_all_sources is OK. Once you write the docs for this, you can figure if this works or not.
There was a problem hiding this comment.
Squeezing this into tonight's release -- let me know if there are any follow up tweaks you want to see to the docs or this PR and I can get them in a subsequent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Maybe we can allow an option
install_search_all_sourceswhere its possible to still consider all sources eligible for install, since the hashes of the lock file were generated from index restricted packages and are pinned to specific versions and hashes in the lockfile.The fix
Fix #5041
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.