4998 remove long broken pipreqs usage #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
commented
Mar 21, 2022
|
|
||
| c = p.pipenv('check --unused .') | ||
| assert 'click' not in c.stdout | ||
| assert 'flask' not in c.stdout |
There was a problem hiding this comment.
Notice that it doesn't check that requests is actually in the c.stdout because if it had done that, it would have been obvious this hasn't been working in ages.
oz123
requested changes
Mar 21, 2022
There was a problem hiding this comment.
I am totally fine with this.
Also notice, you can should drop docopt!
bndr/pipreqs#294
Also remove dependencies:
yarg
docopt
oz123
force-pushed
the
4998-remove-long-broken-pipreqs-usage
branch
from
cce4505 to
adcebfd
Compare
oz123
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove option --code from install and --unused from check which has been broken since 2018. Also removed unused args from check command, and removed the vendored dependencies:
The issue
For more details on rationale:
#4998
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.