-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative git ssh module having ssh:// appended #2441
Comments
I have managed to install the package by editing the Pipfile manually with the following:
I tried to add the package through pipenv but it kept getting transformed (either the |
Fixing one bug, causing another 💥 We need to be smarter deciding how to fix the SSH URL. |
It's not about being smarter, it's literally just a bug. It's super easy to decide. The logic is incredibly straightforward. |
- Updated requirementslib - Fix local relative path bug whici caused paths to be output as absolute (test added to requirementslib) - Fix SSH normalization bug (test added to requirementslib) - Fixes #2440, #2441 Signed-off-by: Dan Ryan <[email protected]>
- Updated requirementslib - Fix local relative path bug whici caused paths to be output as absolute (test added to requirementslib) - Fix SSH normalization bug (test added to requirementslib) - Fixes #2440, #2441 Signed-off-by: Dan Ryan <[email protected]>
Closed by #2453 |
I'm trying to install my Pipenv environment on a new machine and have upgraded pipenv from 2018.05.18 to 2018.06.25. A module which I'm pulling from git is now no longer installing with the following error:
Pipenv appears to be appending
ssh://
to the URL where it previously hasn't.Expected result
The module is installed
Actual result
The module is not installed
Steps to replicate
Try to install the module
EDIT: I've investigated trying to install the module via the command line and get the following output:
Relative Git URL
Command:
Error:
Absolute Git URL
Command:
Error:
It looks like the
ssh://
is being appended to the relative URL instead of the absolute URL.The text was updated successfully, but these errors were encountered: