Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative git ssh module having ssh:// appended #2441

Closed
typhoon2099 opened this issue Jun 27, 2018 · 4 comments
Closed

Relative git ssh module having ssh:// appended #2441

typhoon2099 opened this issue Jun 27, 2018 · 4 comments
Labels
Category: VCS Relates to version control system dependencies. Type: Bug 🐛 This issue is a bug.
Milestone

Comments

@typhoon2099
Copy link

typhoon2099 commented Jun 27, 2018

I'm trying to install my Pipenv environment on a new machine and have upgraded pipenv from 2018.05.18 to 2018.06.25. A module which I'm pulling from git is now no longer installing with the following error:

Command "git clone -q ssh://[email protected]:redacted/redacted.git /home/redacted/.local/share/virtualenvs/redacted-eQF46Ow3/src/redacted" failed with error code 128 in None

Pipenv appears to be appending ssh:// to the URL where it previously hasn't.


Expected result

The module is installed

Actual result

The module is not installed

Steps to replicate

Try to install the module

EDIT: I've investigated trying to install the module via the command line and get the following output:

Relative Git URL
Command:

pipenv install -e [email protected]:company/[email protected]#egg=libb

Error:

Command "git clone -q ssh://[email protected]:company/library.git /tmp/tmpENxA1wsource/library" failed with error code 128 in None

Absolute Git URL
Command:

pipenv install -e [email protected]/company/[email protected]#egg=libb

Error:

Command "git clone -q [email protected]/company/library.git /home/employee/.local/share/virtualenvs/library-joI2jbUq/src/libb" failed with error code 128 in None

It looks like the ssh:// is being appended to the relative URL instead of the absolute URL.

@typhoon2099
Copy link
Author

I have managed to install the package by editing the Pipfile manually with the following:

libbb = {ref = "1.0.0-rc2", git = "[email protected]/company/library", editable = true}

I tried to add the package through pipenv but it kept getting transformed (either the .git appended or the ssh:// appended).

@uranusjr
Copy link
Member

Fixing one bug, causing another 💥

We need to be smarter deciding how to fix the SSH URL.

@techalchemy
Copy link
Member

It's not about being smarter, it's literally just a bug. It's super easy to decide. The logic is incredibly straightforward.

@techalchemy techalchemy added Type: Bug 🐛 This issue is a bug. Category: VCS Relates to version control system dependencies. labels Jun 27, 2018
techalchemy added a commit that referenced this issue Jun 28, 2018
- Updated requirementslib
- Fix local relative path bug whici caused paths to be output as
  absolute (test added to requirementslib)
- Fix SSH normalization bug (test added to requirementslib)
- Fixes #2440, #2441

Signed-off-by: Dan Ryan <[email protected]>
@techalchemy techalchemy added this to the 2018.7.0 milestone Jun 28, 2018
techalchemy added a commit that referenced this issue Jun 28, 2018
- Updated requirementslib
- Fix local relative path bug whici caused paths to be output as
  absolute (test added to requirementslib)
- Fix SSH normalization bug (test added to requirementslib)
- Fixes #2440, #2441

Signed-off-by: Dan Ryan <[email protected]>
@techalchemy
Copy link
Member

Closed by #2453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: VCS Relates to version control system dependencies. Type: Bug 🐛 This issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants