Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in NEWS.rst #9934

Merged
merged 1 commit into from
May 1, 2021
Merged

Fix typo in NEWS.rst #9934

merged 1 commit into from
May 1, 2021

Conversation

dmerejkowsky
Copy link
Contributor

No description provided.

@dmerejkowsky
Copy link
Contributor Author

I found a typo while reading the changelog and tried to fix it. I'm not sure how to do that, since the file that was used to generate NEWS.rst is now gone ...

Also, the new-file/pr check is failing but I'm not sure why.

Please advise - maybe we need to update the development guide?

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label May 1, 2021
@dmerejkowsky
Copy link
Contributor Author

Answering my own question: you just need for a maintainer to add the "trivial" label manually - Gotcha.

Thanks :)

@sbidoul sbidoul merged commit e6414d6 into pypa:main May 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants