Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python2 related stuff in tests #9579

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Drop python2 related stuff in tests #9579

merged 1 commit into from
Feb 23, 2021

Conversation

hexagonrecursion
Copy link
Contributor

Progress toward #8802

@hexagonrecursion
Copy link
Contributor Author

hexagonrecursion commented Feb 10, 2021 •
edited
Loading

news-file/pr — Missing either a news entry or a trivial file/label

I don't understand. I did add news/fc6b6951-9a1a-453e-af98-bbb35f7c3e66.trivial.rst

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 10, 2021
@uranusjr
Copy link
Member

The detection bot has been buggy for a while, don’t worry about it.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 21, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 21, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 23, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 23, 2021
@pradyunsg pradyunsg merged commit f4f35ba into pypa:master Feb 23, 2021
@hexagonrecursion hexagonrecursion deleted the the-future-is-now branch February 23, 2021 13:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hexagonrecursion @uranusjr @BrownTruck @pradyunsg @pypa-bot