Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated support for VCS pseudo URLs #9436

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Remove deprecated support for VCS pseudo URLs #9436

merged 5 commits into from
Jan 19, 2021

Commits on Jan 18, 2021

  1. Construct valid backends list for error message.

    @sbidoul
    sbidoul committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    5385d8a View commit details
    Browse the repository at this point in the history

  2. Remove support for git+git@ pseudo VCS URLs. 

    Now that we don't need to support git@
pseudo-urls, we can simplify the test for
valid VCS URLs based on link.is_vcs, which
is turns is based on the URL scheme.

This also means we fail earlier if a git@ pseudo
URL is used.

Since VCS requirements are not validated to be URLs
in Requirement constructors, we can simplify update_editable.
    @sbidoul
    sbidoul committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    b3761f6 View commit details
    Browse the repository at this point in the history

  3. Improve syntax 

    Co-authored-by: Xavier Fernandez <[email protected]>
    @sbidoul @xavfernandez
    sbidoul and xavfernandez committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    28bbf89 View commit details
    Browse the repository at this point in the history

  4. Remove unused VCS schemes 

    These schemes without + are support in an ad-hoc fashion in
parse_editable_requirement.
    @sbidoul
    sbidoul committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    78b891a View commit details
    Browse the repository at this point in the history

  5. Show full list of supported VCS scheme in error message 

    When an editable requirement is neither a local directory nor
a URL with a supported VCS scheme, we show the full list
of supported VCS schemes in the error message.
    @sbidoul
    sbidoul committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    7ee22ba View commit details
    Browse the repository at this point in the history