Use Formatter.default_time_format after dropping PY2 #9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
force-pushed
the
rm-2-default_time_format
branch
from
688e270
to
0b012d7
Compare
|
Thanks, how does this look now? |
uranusjr
reviewed
Dec 27, 2020
uranusjr
added
the
skip news
hugovk
force-pushed
the
rm-2-default_time_format
branch
from
0b012d7
to
b92c0c1
Compare
pradyunsg
approved these changes
Dec 27, 2020
uranusjr
approved these changes
Dec 27, 2020
xavfernandez
approved these changes
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8802.
Do a TODO
and update tests to match.# TODO: Use Formatter.default_time_format after dropping PY2.