Update message displayed on conflicts post-resolution #9124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
the
skip news
brainwane
approved these changes
Nov 18, 2020
uranusjr
reviewed
Nov 19, 2020
| "or updating packages. This is because pip will change the " | ||
| "way that it resolves dependency conflicts.\n" | ||
| "pip's legacy dependency resolver does not consider dependency " | ||
| "conflicts when selecting packages. This behaviour is the " |
There was a problem hiding this comment.
Kind of OT, dwe have style guides on what spelling to use in error messages?
There was a problem hiding this comment.
Not really. It's a flip-a-coin-and-pick-one spelling approach right now.
As for the exact wording, that's getting iterated on in the issue, so it's mostly a "does everyone agree it's good enough". :P
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7744