Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver: stabilize output for tests (& users) #9076

Conversation

xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Oct 30, 2020

Otherwise the test_install_distribution_union_with_versions test can end
up with either:

Cannot install localextras[bar] 0.0.2 and localextras[baz] 0.0.1 because these package versions have conflicting dependencies.

or

Cannot install localextras[baz] 0.0.2 and localextras[bar] 0.0.1 because these package versions have conflicting dependencies.

Otherwise the test_install_distribution_union_with_versions test can end
up with either:

    Cannot install localextras[bar] 0.0.2 and localextras[baz] 0.0.1 because these package versions have conflicting dependencies.

or

    Cannot install localextras[baz] 0.0.2 and localextras[bar] 0.0.1 because these package versions have conflicting dependencies.
@xavfernandez xavfernandez added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 30, 2020
@xavfernandez
Copy link
Member Author

An alternative could be to replace

assert "Cannot install localextras[bar]" in result.stderr

by assert "Cannot install localextras" in result.stderr

But explicitly stabilizing the output might be worthwhile on its own (except if the current order is meaningful, which does not seem the case in Python 3.5).

@pradyunsg
Copy link
Member

Did I not change this already in #9019? Huh.

@pradyunsg pradyunsg merged commit 24621f7 into pypa:master Oct 31, 2020
@xavfernandez xavfernandez deleted the fix_test_install_distribution_union_with_versions branch October 31, 2020 09:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants