Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated file mode to use bitwise AND #8166

Merged
merged 4 commits into from
Apr 30, 2020

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented Apr 29, 2020

Fixes and closes #8164

Taking a bitwise AND with the negation of current umask, instead of subtracting the value.

https://unix.stackexchange.com/questions/430616/why-do-some-umask-values-not-take-effect

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deveshks thanks! A couple of minor comments.

tests/unit/test_wheel.py Outdated Show resolved Hide resolved
news/8164.bugfix Outdated Show resolved Hide resolved
@deveshks deveshks force-pushed the fix-generated-file-mode branch from 49079af to 9319703 Compare April 29, 2020 06:17
tests/unit/test_wheel.py Outdated Show resolved Hide resolved
@deveshks deveshks requested a review from sbidoul April 29, 2020 07:08
@pradyunsg pradyunsg modified the milestone: 20.1 Apr 29, 2020
@pradyunsg pradyunsg added this to the 20.1.1 milestone Apr 30, 2020
@pradyunsg pradyunsg merged commit 612970b into pypa:master Apr 30, 2020
@deveshks deveshks deleted the fix-generated-file-mode branch April 30, 2020 04:53
pradyunsg added a commit to pradyunsg/pip that referenced this pull request May 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect file permissions in dist-info directory after installing a package
5 participants