-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if package index gets unexpected Content-Type #8083
Warn if package index gets unexpected Content-Type #8083
Conversation
d56f79e
to
c66149b
Compare
I note all error reports in this area are |
I think we can change https://github.com/pypa/pip/blob/master/src/pip/_internal/index/collector.py#L437 and https://github.com/pypa/pip/blob/master/src/pip/_internal/index/collector.py#L453 , both to Perhaps: https://github.com/pypa/pip/blob/master/src/pip/_internal/index/collector.py#L411 as well, but this lies outside |
980359e
to
103a4d6
Compare
As per #8083 (comment) , can I extend the scope of this issue, as well as the associated PR to include the remaining two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor wording nit
I'm happy to have changing the other messages' level be in a separate PR. I'm not entirely sure that the other messages even should be changed to warnings - IMO that should be discussed and decided on a case by case basis, so a separate PR seems correct. |
I have gone ahead and create an issue to discuss this #8128 , and get some agreement before creating a PR for the same |
If there are no more changes necessary to be done in this PR, may I get this merged? |
91c01e3
to
64c78b1
Compare
Fixes and closes #6754