New Resolver: Implement equality on candidate classes #7976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
pfmoore
approved these changes
Apr 4, 2020
|
Maybe just add a comment to the |
|
Sounds reasonable, added. |
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
uranusjr
force-pushed
the
installed-candidate-equal
branch
from
6ff8dd8 to
591d476
Compare
uranusjr
changed the title
pradyunsg
approved these changes
Apr 9, 2020
| return self.base == other.base and self.extras == other.extras | ||
| return False | ||
|
|
||
| # Needed for Python 2, which does not implement this by default |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this one is self-explainatory.
RequiresPythonCandidatedoes not need this because there will always be exactly one instance, so the built-inobject.__eq__is sufficient. Or maybe it would be more obvious if we implement it anyway withself is other?