-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packaging to 20.3 #7852
Conversation
c5bb46f
to
48f90da
Compare
Any chance to get this reviewed :) @pradyunsg @chrahunt |
Is there a particular pressing need for this upgrade? I believe it is generally preferred to upgrade vendor packages before a new pip release instead to avoid repetitive PRs. |
(To clarify, the PR itself LGTM.) |
Note we have at least one bug that depends on an open packaging PR: pypa/packaging#264 |
The PR looks good to me but I see no reason to bump the version now, this will be done prior to releasing pip 20.1. |
I have no issues with waiting. Let's just keep this open for a bit; until April. :) |
A few benefits of not waiting:
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
This has already been done in 2694496 . Probably no need to merge this one. Thanks! |
cc @pradyunsg @bdwyer2