Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packaging to 20.3 #7852

Closed
wants to merge 1 commit into from
Closed

Upgrade packaging to 20.3 #7852

wants to merge 1 commit into from

Conversation

xuhdev
Copy link

@xuhdev xuhdev commented Mar 12, 2020

@xuhdev xuhdev force-pushed the packaging branch 7 times, most recently from c5bb46f to 48f90da Compare March 13, 2020 21:08
@xuhdev
Copy link
Author

xuhdev commented Mar 23, 2020

Any chance to get this reviewed :) @pradyunsg @chrahunt
@xavfernandez

@uranusjr
Copy link
Member

Is there a particular pressing need for this upgrade? I believe it is generally preferred to upgrade vendor packages before a new pip release instead to avoid repetitive PRs.

@uranusjr
Copy link
Member

(To clarify, the PR itself LGTM.)

@sbidoul
Copy link
Member

sbidoul commented Mar 24, 2020

Note we have at least one bug that depends on an open packaging PR: pypa/packaging#264

@xavfernandez
Copy link
Member

The PR looks good to me but I see no reason to bump the version now, this will be done prior to releasing pip 20.1.

@pradyunsg
Copy link
Member

I have no issues with waiting. Let's just keep this open for a bit; until April. :)

@pradyunsg pradyunsg added project: vendored dependency Related to a vendored dependency type: maintenance Related to Development and Maintenance Processes labels Mar 26, 2020
@chrahunt
Copy link
Member

A few benefits of not waiting:

  1. if the new release introduces any bugs or incompatibilities, we're more likely to catch them
  2. compatibility is ensured with each PR instead of one PR near the release date - potentially less work later

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Apr 17, 2020
@xuhdev
Copy link
Author

xuhdev commented Apr 17, 2020

This has already been done in 2694496 . Probably no need to merge this one. Thanks!

@xuhdev xuhdev closed this Apr 17, 2020
@xuhdev xuhdev deleted the packaging branch April 17, 2020 03:41
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master project: vendored dependency Related to a vendored dependency type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants