Do not update no_clean option value in install/wheel
#7771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a recent refactoring of our temporary directory handling, `no_clean` is only read prior to these `except` blocks. Since it's not needed, remove it!
chrahunt
changed the title
no_clean option value in install/wheel
chrahunt
added
skip news
xavfernandez
approved these changes
Feb 23, 2020
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a recent refactoring of our temporary directory cleanup (#7696),
no_cleanis only read prior to theseexcepthandlers, so we don't need to update its value anymore.This makes the code easier to reason about (less mutability) and lets us get rid of a level of indentation.
in
WheelCommand.