Move find_egg_info to operations.generate_metadata #7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: refactor
pradyunsg
force-pushed
the
refactor/move-find_egg_info
branch
from
8b69951
to
5fa4ae0
Compare
This comment has been minimized.
This comment has been minimized.
Why: This enables a simplification in a follow up and AFAICT, they'll be the same here.
pradyunsg
force-pushed
the
refactor/move-find_egg_info
branch
from
5fa4ae0
to
b21f4c9
Compare
|
I'mma be a bit off handed and merge this in today. It'd be nice if someone could review this but I don't mean to force anyone's hand here. I don't think anyone would have broader concerns with this change which is the only reason I'm OK with doing this. I'm happy to iterate on these changes if there are any post-merge concerns flagged. :) |
|
LGTM. 👍 |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves and improves find_egg_info.
This also means that we no longer make calls into InstallRequirement for metadata generation of legacy distributions! (Yay!)
We're still doing validation in prepare_metadata but baby steps.