Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add requirement parsing module. #7020

Closed
wants to merge 9 commits into from
Closed

WIP: Add requirement parsing module. #7020

wants to merge 9 commits into from

Commits on Sep 15, 2019

  1. Add requirement parsing module.

    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    a2112f1 View commit details
    Browse the repository at this point in the history

  2. Move _strip_extras. 

    This prevents a circular import since req.constructors will depend on
req.parsing.
    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    47a76f5 View commit details
    Browse the repository at this point in the history

  3. Use parse_requirement_text in install_req_from_line. 

    To start, we use the parsed link instead of populating it in several
places.

We no longer need to normalize relative URLs since the requirement
string must be either:

1. a relative path (e.g. `.` or `./example`), which gets normalized
   by `parse_requirement_text`, or
2. an absolute file URL
    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    bd77439 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded directory format check. 

    Since the lower-level parsing already determined it's a file path,
we can just check whether it's a directory.
    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    9bf3804 View commit details
    Browse the repository at this point in the history

  5. Move error hints text to new parsing block. 

    A single '=' may only be applicable to direct references or named
references, since they are the ones that allow version specifiers.
    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    dae1278 View commit details
    Browse the repository at this point in the history

  6. Enforce that file path requirements exist. 

    Previously, non-existent file paths were falling through to the
Requirement parsing and it was failing at that point. Now we
specifically require that any mentioned files exist.
    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    36781cd View commit details
    Browse the repository at this point in the history

  7. Derive requirement from wheel name if available.

    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    2bdbb81 View commit details
    Browse the repository at this point in the history

  8. Derive markers and extras from RequirementInfo.

    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    50c5282 View commit details
    Browse the repository at this point in the history

  9. Fix string formatting style, add req source.

    @chrahunt
    chrahunt committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    a1548fa View commit details
    Browse the repository at this point in the history