Add "list" pip command #675
Conversation
|
Travis-ci where are you? |
|
@rafaelcaricio This is looking great, thanks for working on it! I probably can't do a full review this week, but I'll try to get to it early next week. As I mentioned on #664 I think Also, somehow my "rename 'status' command 'show'" commit got rebased into this pull request's history with a different commit hash; not sure how that happened. |
|
Hm, I did a "git rebase" in order to keep my branch updated with the original develop branch. So why it happend is discussed here. |
|
Hello, |
| req.check_if_exists() | ||
| yield req | ||
|
|
||
| def find_packeages_latests_versions(self, options): |
There was a problem hiding this comment.
"packeages" is a mis-spelling, should be "packages"
|
Hi @rafaelcaricio - sorry I didn't get to review this as quickly as I thought I would. I just looked over it now and it looks good to me, apart from the minor comments I made. At some point the duplication could be factored out between the options to this command and the options to I'm actually leaving pip/virtualenv development, so I don't want to actually merge-and-run here and leave the other devs to deal with it :-) But it has my +1 if @jezdez or @brosner or @qwcode or @pnasrat feels like merging it. |
|
If you can ensure it's mergable I'll happily take another look. |
|
@pnasrat , @rafaelcaricio I was going to look at this, but since paul is on the case, I'll just focus on other pulls. |
|
I'm guessing the rename commit is the issue with mergability (the rename is already in develop). I cloned your repo and was able to rebase |
|
Hi @qwcode is it what you wanted to me to do? |
|
oh, I'm wondering if what I saw last night was the "merge with caution" due to the tests failing, and not the mergability warning. in any case, the rebase looks good, but that one test that's failing... looks like travis randomness, but do you care to force push again with some minor comment change to get a clean run? |
|
Ok @qwcode, now it is passing! :) |
|
@rafaelcaricio so it looks like all the commits are duplicated in here. hmm. |
|
@qwcode I just did something wrong. :( |
|
@rafaelcaricio , no worries. looks like you merged with gvalkov's branch, which was a rebase (which results in new commits), so you ended up with the duplication. I'll open another pull today or tomorrow that grabs your first set of commits, and handles the remaining details. then get a final kumbaya from folks, and merge. |
|
probably be saturday when I do this... |
|
closing this one to make sure this doesn't get merged with the duplicate commits. |
lock
bot
added
the
auto-locked
This request was originally made by @dgladkov in the issue #235. I just get all the contributions made in the another issue (by @maraujop and @dgladkov) and extended the idea implementing my understanding about a idea for this command made by @jezdez in the same issue. I didn't implemented all the commands because I wanna to hear from you.
I think this command is extremity useful for the all users and I think that command could fit better to pip than my other contribution #664. What I'm trying to say is that maybe a extension in this command can fit better. What do you think guys? I can make more modifications in this pull request if necessary, just tell me what I can do.
Cheers,