-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pip download to respect --python-version #6577
Update pip download to respect --python-version #6577
Conversation
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
ab9c249
to
88990a3
Compare
051b793
to
0444dda
Compare
@xavfernandez In this PR, similar to your suggestion here, I'm making e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some places, we restrict py_version_info
to a 3-int-tuple but apparently complete_version_info
is capable of letting longer tuple pass unchanged, I think we should be consistent and might want to always have the same type and change the typing hints to Tuple(int, int, int)
everywhere...
But after Requires-Python
, it is likely that users will also want that pip uses --python-version
when evaluating some environment markers like python_version
, python_full_version
& implementation_version
.
And to do so, pip will need more than the 3-int tuple so we'll certainly end up with a 5-tuple as defined by https://docs.python.org/fr/3/library/sys.html#sys.version_info definition but this would certainly be for an other PR :)
2ceba72
to
494fad8
Compare
@xavfernandez Thanks for the suggestion. I renamed By the way, here's an existing issue related to environment markers along the lines you said: #6117 It also has an associated PR (PR #6357) that I gave pointers on. |
494fad8
to
8dbf88d
Compare
Thanks again for reviewing, @xavfernandez. |
Thanks for doing this @cjerdonek and reviewing this @xavfernandez! :) |
Fixes #5369.