Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip download VCS scp-like URLs #6296

Closed
wants to merge 2 commits into from

Conversation

atugushev
Copy link
Contributor

For example: git+user@hostname:user/repo.git
Fixes #6293.

For example: git+user@hostname:user/repo.git
@atugushev
Copy link
Contributor Author

Huh, for integrational tests there has to be deploy key with RO access to https://github.com/pypa/pip-test-package. Can someone help me to deal with it?

Command "git clone -q [email protected]:pypa/pip-test-package.git /tmp/pytest-of-travis/pytest-0/popen-gw1/test_download_vcs_scp_like_url0/workspace/tmp/pip-req-build-oX40kZ" failed with error code 128 in None
-- stdout: --------------------
Collecting [email protected]:pypa/pip-test-package.git
  Cloning [email protected]:pypa/pip-test-package.git to /tmp/pytest-of-travis/pytest-0/popen-gw1/test_download_vcs_scp_like_url0/workspace/tmp/pip-req-build-oX40kZ
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

@pradyunsg pradyunsg closed this Feb 24, 2019
@pradyunsg pradyunsg reopened this Feb 24, 2019
@pradyunsg
Copy link
Member

Seems like something intermittent. Closed and opened to retrigger the tests.

@atugushev
Copy link
Contributor Author

@pradyunsg thank you. But, the thing is i've added an integrational test which installs a test package from another github repository [email protected]:pypa/pip-test-package.git over SSH (git+git@..., which is git+ssh://) and it wants a deploy key now. Locally tests are fine, for i have the github's user ssh-key.

Anyways, it seems members are considering to drop support scp-like URLS in the related issue. May be it's not worth to spend a time on it.

@pradyunsg
Copy link
Member

I don't have the bandwidth to review right now. Sorry!

@pradyunsg pradyunsg added the S: needs triage Issues/PRs that need to be triaged label Mar 5, 2019
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 8, 2019
@atugushev atugushev closed this Jul 2, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
@pradyunsg pradyunsg removed the S: needs triage Issues/PRs that need to be triaged label Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong return value of a Link.is_artifact for git+user@hostname editable packages
3 participants