Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better error message for editable installs attempted with pyproject.toml #6206

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented Jan 26, 2019

This addresses #6170.

The error message looks like this:

File "setup.py" not found. Directory cannot be installed in editable mode: <absolute-dir-path>
(A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.)

@cjerdonek cjerdonek added type: enhancement Improvements to functionality C: editable Editable installations C: PEP 517 impact Affected by PEP 517 processing labels Jan 26, 2019
@cjerdonek cjerdonek modified the milestones: 19.0, Print Better Error Messages Jan 26, 2019
@cjerdonek cjerdonek force-pushed the better-no-setup-py-error-message branch from 866692b to 083346c Compare January 26, 2019 14:38
@cjerdonek cjerdonek force-pushed the better-no-setup-py-error-message branch from 083346c to d619aba Compare January 26, 2019 14:59
The message looks like this:

  File "setup.py" not found. Directory cannot be installed in editable
  mode: <absolute-dir-path>
  (A "pyproject.toml" file was found, but editable mode currently
  requires a setup.py based build.)
@cjerdonek cjerdonek modified the milestones: Print Better Error Messages, 19.0 Jan 29, 2019
@pradyunsg pradyunsg requested a review from pfmoore January 29, 2019 10:25
@cjerdonek
Copy link
Member Author

Note: the error message is more or less quoting @dstufft from here: #6170 (comment)

@pradyunsg
Copy link
Member

I noticed. :P

@pradyunsg pradyunsg removed the request for review from pfmoore January 31, 2019 03:11
@pradyunsg
Copy link
Member

Will be in 19.0.2.

@lock
Copy link

lock bot commented May 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: editable Editable installations C: PEP 517 impact Affected by PEP 517 processing type: enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants