-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5889 which occurs when comes_from.link
is None
#6082
Conversation
OK. Now I see that the test has issues. |
Yes, you can't use |
FWIW, pypa/packaging#115, was merged and packaging 19 is now vendored in pip. |
9f94750
to
590fdba
Compare
* allow calling it with `comes_from=None` (easier for testing) * handle the case where `comes_from.link is None` (which can happen if a package using a PEP 508 URL requirement is already installed)
590fdba
to
b422cae
Compare
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
@xavfernandez Can this be closed because of PR #6336 just merged? |
Indeed |
Thanks @ircwaves for the initial PR though |
@xavfernandez -- I'll pass those thanks on back to @benoit-pierre, @cjerdonek, and @aloosley. I just wish my bandwidth had allowed me to get more involved and push the fix through. Thanks to all for their efforts, of any measure. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes issue #5889, which blocks a private-package use case of installing a package C, that requires package B via a direct URL requirement, which requires A via direct URL requirement (a la pep508).
@benoit-pierre said:
On benoit-pierre's PR #5893, @cjerdonek suggested that a slimmer PR might be better, so here it is. This may be a total faux pas, but I've cherry-picked the commit he made, as it fixes issue #5889.
I see that on the PR #5893 @cjerdonek asked for a unit test, but I'm not familiar enough with pip internals to set up that unit test. The test that benoit-pierre wrote should ensure that there isn't a regression that blocks this use-case again.