Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn attributes on HTMLPage into local variables and standalone functions #5826

Merged
merged 9 commits into from
Sep 29, 2018
Merged

Turn attributes on HTMLPage into local variables and standalone functions #5826

merged 9 commits into from
Sep 29, 2018

Commits on Sep 28, 2018

  1. Extract base URL parsing logic

    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    96a3254 View commit details
    Browse the repository at this point in the history

  2. Convert base_url property into local variable 

    This property is only used in HTMLPage.links, which is only called once
per instance in PackageFinder.find_all_candidates(). This would not
affect performance or behavior, but improves data locality.

The unit test of this property is and modified to test the underlying
function instead.
    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    40bf368 View commit details
    Browse the repository at this point in the history

  3. Extract encoding detection into helper function

    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    94d0428 View commit details
    Browse the repository at this point in the history

  4. Convert HTMLPage.parsed into a local variable 

    This attribute is only used by HTMLPage.links, which is only used once
per instance in PackageFinder.find_all_candidates(), so this change does
not affect performance or behavior, but improves data locality.
    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    28ef0c2 View commit details
    Browse the repository at this point in the history

  5. Refactor _parse_base_url to use early return

    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    dc7e6b5 View commit details
    Browse the repository at this point in the history

  6. News fragment

    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    69e1e18 View commit details
    Browse the repository at this point in the history

  7. Rename base URL detection function

    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    aa83222 View commit details
    Browse the repository at this point in the history

  8. Rename HTMLPage.links to clarify its purpose

    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    47ba191 View commit details
    Browse the repository at this point in the history

  9. Move clean_link out of HTMLPage

    @uranusjr
    uranusjr committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    6f85fcd View commit details
    Browse the repository at this point in the history