Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve PEP 518 build isolation #5824

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

benoit-pierre
Copy link
Member

Handle .pth files, so namespace packages are correctly supported under Python 3.2 and earlier.

Fix #5656.

Handle .pth files, so namespace packages are correctly supported
under Python 3.2 and earlier.
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine. My only doubt is about why we want to add support code for functionality in Py < 3.2. Does it include Py 2.7?

If so, it might be useful to mention why/when handling .pth is needed in the comment - either in code or here.

@benoit-pierre
Copy link
Member Author

benoit-pierre commented Sep 28, 2018

Supporting namespace packages is one obvious use of ".pth" files, but note that there are other use-cases (hence needed for Python 3.3 and later), see jaraco/pip-run#29.

@pradyunsg pradyunsg merged commit 83b879b into pypa:master Oct 16, 2018
@benoit-pierre benoit-pierre deleted the improve_build_isolation branch October 16, 2018 09:16
@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation PEP implementation Involves some PEP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace packages in pkg_resources style are not supported in build environment
3 participants