Add unit tests for egg_info_matches #5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
htmlpage-clean
branch
2 times, most recently
from
f7898ab
to
a479d5d
Compare
pradyunsg
approved these changes
Sep 27, 2018
cjerdonek
reviewed
Sep 27, 2018
cjerdonek
approved these changes
Sep 27, 2018
|
It’s up to you. Just thought I’d let you know in case you weren’t aware.
…On Thu, Sep 27, 2018 at 9:14 PM Tzu-ping Chung ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/unit/test_index.py
<#5821 (comment)>:
> @@ -154,3 +154,33 @@ def test_get_formatted_locations_basic_auth():
result = finder.get_formatted_locations()
assert 'user' not in result and 'pass' not in result
+
+
***@***.***(
+ ("egg_info", "search_name", "expected"),
I wrote it this way to match the style of test_filename above. I’m happy
to oblige if this is not a preferred style :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5821 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVt7rvlJYGwArcAb0XGp3z61tAWW8kgks5ufaJBgaJpZM4W9B3r>
.
|
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
uranusjr
force-pushed
the
htmlpage-clean
branch
from
a479d5d
to
00c043d
Compare
|
@cjerdonek's first merge. 🎉 |
|
Yes, thanks! 🍻 I figured I'd start with some tests. :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the bug fix part of #5819.