Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration handling #5798

Merged
merged 5 commits into from
Oct 4, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bodge: Allow both str and repr to be used for configuration file name
This is because Python 2's and Python 3's configparser treat the two
differently and we're reusing that message.
pradyunsg committed Oct 3, 2018
commit 3350cc45161a3024634cb4e22cdc46bfb80dfa04
5 changes: 4 additions & 1 deletion tests/unit/test_configuration.py
Original file line number Diff line number Diff line change
@@ -80,7 +80,10 @@ def test_environment_config_errors_if_malformed(self):

assert "section header" in str(err.value) # error kind
assert "1" in str(err.value) # line number
assert repr(config_file) in str(err.value) # file name
assert ( # file name
config_file in str(err.value) or
repr(config_file) in str(err.value)
)


class TestConfigurationPrecedence(ConfigurationMixin):