-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pip install -e uninstall existing versions #3898
Make pip install -e uninstall existing versions #3898
Conversation
by adding an additional call to `requirement.check_if_exists()` to RequirementSet.install Fixes pypaGH-1548
Add a comment that says something like "when installing editables, nothing pre-existing should ever satisfy". Addresses @qwcode's comment at pypa#1552 (comment)
Addresses @qwcode's comment at pypa#1552 (comment)
expect_error=True
But only when pip has collected the editable package's metadata. closes pypa#1548
I'm really excited about this. The more I can verify that this is working for me, especially since prior editable installs have caused a problem where uninstall fails, due to an inverted priority:
|
This looks fine to me. I'm not sure the behaviour is exactly what I'd expect but shrug. |
The OpenStack community would love to see this (or something) merged to solve the editable installs problem introduced by setuptools 25.0.0. We only just now discovered that projects using tox with usedevelop=True in our CI have not actually been testing the source code we expected if something else has already dragged in a packaged version of them as a transitive dependency. |
Based on #1552