Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1519 from dstufft/remove-dependency-links" #1955

Merged
merged 1 commit into from
Aug 4, 2014

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented Aug 1, 2014

This reverts commit da02f07, reversing changes made to 2ad8888.

Conflicts:
CHANGES.txt
pip/commands/freeze.py
pip/commands/list.py
pip/commands/wheel.py
pip/index.py
pip/req/req_set.py
pip/vcs/subversion.py

…inks"

This reverts commit da02f07, reversing
changes made to 2ad8888.

Conflicts:
	CHANGES.txt
	pip/commands/freeze.py
	pip/commands/list.py
	pip/commands/wheel.py
	pip/index.py
	pip/req/req_set.py
	pip/vcs/subversion.py
@Ivoz
Copy link
Contributor

Ivoz commented Aug 2, 2014

You write any discussion on what caused change in opinion from removing it?

@dstufft
Copy link
Member Author

dstufft commented Aug 2, 2014

Nothing in particular. I've seen a number of people worried that this change hurts their ability to distribute their private packages. Even Metadata 2.0 recognizes this use case however I'm not sure that there is a good reason to break this use case for people until Metadata 2.0 exists and can replace it.

@qwcode
Copy link
Contributor

qwcode commented Aug 3, 2014

+1

@pradyunsg
Copy link
Member

@dstufft @qwcode As on today, what needs to be done to remove dependency link support from pip?

Is there some existing discussion for this? #4187 is in quite the opposite direction. Does this need to happen on Warehouse?

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants