Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyedit news entries before 25.0 #13174

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Copyedit news entries before 25.0 #13174

merged 1 commit into from
Jan 25, 2025

Conversation

ichard26
Copy link
Member

No description provided.

@ichard26 ichard26 added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 24, 2025
@ichard26 ichard26 added this to the 25.0 milestone Jan 24, 2025
@ichard26 ichard26 requested a review from sbidoul January 24, 2025 23:10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notatallshaw AFAIU, the change was made in packaging in order to better comply with the specification, thus this is moreso a bugfix IMO. Also, it's just really strange to put this under "Features" ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it should have been a bugfix.

@sbidoul sbidoul merged commit d265fb7 into pypa:main Jan 25, 2025
11 checks passed
@sbidoul
Copy link
Member

sbidoul commented Jan 25, 2025

Thanks @ichard26, much appreciated!

@ichard26 ichard26 deleted the changelog branch January 25, 2025 18:47
@ichard26 ichard26 removed the request for review from sbidoul January 25, 2025 18:47
@sbidoul
Copy link
Member

sbidoul commented Jan 26, 2025

I took the liberty to also move the requirements decoding entry to the bugfix section as this change is essentially to better match our documented behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants